feat: add OS notifications for completed/failed tasks#976
feat: add OS notifications for completed/failed tasks#976yehyal wants to merge 5 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
| const previous = lastSessionByThreadRef.current.get(thread.id); | ||
|
|
||
| // A completed/failed turn transitions from running with an activeTurnId | ||
| // to a session with no active turn and status ready/error. |
There was a problem hiding this comment.
should also notify on input/approval requested?
also maybe have the setting be more configurable than a boolean flag so users can set more granular levels of when they wanna be notified
There was a problem hiding this comment.
I wanted to push out a mvp first for just task status notification, but I can definitely work on adding it for input/approval
can you give me a bit more info regarding fine tuning the notifications? some example scenarios / levels that you want to add


Summary
Adds OS notifications when a task completes or fails, with a user-facing toggle and a settings test button.
Why
Addresses issue
Notifications are important for backgrounded work. This keeps users in the loop without requiring the app to stay focused.
What Changed
Screenshots / Video
t3code-preview-notification.mp4
Notes
Note
Add OS notifications for completed and failed background tasks
nativeNotificationsutility library (nativeNotifications.ts) with functions to check permission, request permission, detect app backgrounding, and dispatch native notifications.useNotificationhook to track and request Notification API permission state, refreshing on window focus.enableNotificationstoggle (defaulttrue) to app settings, with a settings UI for enabling/disabling notifications, viewing permission status, requesting browser permission, and sending a test notification.enableNotifications: true; users will be prompted for browser notification permission when they visit settings.Macroscope summarized 0a1e63b.